[
https://issues.apache.org/jira/browse/HDFS-7552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253099#comment-14253099
]
Lei (Eddy) Xu commented on HDFS-7552:
-------------------------------------
Thank you so much for the findings, [~xieliang007].
+1 (non-binding)
> change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration
> --------------------------------------------------------------------------
>
> Key: HDFS-7552
> URL: https://issues.apache.org/jira/browse/HDFS-7552
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode, test
> Affects Versions: 2.7.0
> Reporter: Liang Xie
> Assignee: Liang Xie
> Attachments: HDFS-7552-001.txt
>
>
> see
> https://builds.apache.org/job/PreCommit-HDFS-Build/9088//testReport/org.apache.hadoop.hdfs.server.datanode/TestDataNodeVolumeFailureToleration/testValidVolumesAtStartup/
> Per my understanding, it was due to:
> commit 3b173d95171d01ab55042b1162569d1cf14a8d43
> Author: Colin Patrick Mccabe <cmcc...@cloudera.com>
> Date: Wed Dec 17 16:41:59 2014 -0800
> HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via
> Colin P. McCabe)
> - volatile List<FsVolumeImpl> volumes = null;
> + private final AtomicReference<FsVolumeImpl[]> volumes =
> + new AtomicReference<>(new FsVolumeImpl[0]);
> so the old case will complain at here:
> {code}
> assertTrue("The DN should have started with this directory",
> si.contains(dataDir1Actual.getPath()));
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
