[ 
https://issues.apache.org/jira/browse/HDFS-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264471#comment-14264471
 ] 

Haohui Mai commented on HDFS-7583:
----------------------------------

Thanks for working on it.

{code}
LOG.debug("Deleting " + file + " has failed");
{code}

It might make sense to put it into the WARN level. +1 after addressing it.

> Fix findbug in TransferFsImage.java
> -----------------------------------
>
>                 Key: HDFS-7583
>                 URL: https://issues.apache.org/jira/browse/HDFS-7583
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>            Priority: Minor
>         Attachments: HDFS-7583-001.patch
>
>
> Fix following findbug resulting in recent jenkins runs
> {noformat}Exceptional return value of java.io.File.delete() ignored in 
> org.apache.hadoop.hdfs.server.namenode.TransferFsImage.deleteTmpFiles(List)
> Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details) 
> In class org.apache.hadoop.hdfs.server.namenode.TransferFsImage
> In method 
> org.apache.hadoop.hdfs.server.namenode.TransferFsImage.deleteTmpFiles(List)
> Called method java.io.File.delete()
> At TransferFsImage.java:[line 577]{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to