[ https://issues.apache.org/jira/browse/HDFS-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264496#comment-14264496 ]
Haohui Mai commented on HDFS-7578: ---------------------------------- I think in general it is a good change. An easier approach is to use {{Channel#getRemoteAddress()}} when constructing {{RpcResponse}} instead of propagating it everywhere. > NFS WRITE and COMMIT responses should always use the channel pipeline > --------------------------------------------------------------------- > > Key: HDFS-7578 > URL: https://issues.apache.org/jira/browse/HDFS-7578 > Project: Hadoop HDFS > Issue Type: Bug > Components: nfs > Affects Versions: 2.7.0 > Reporter: Brandon Li > Assignee: Brandon Li > Attachments: HDFS-7578.001.patch, HDFS-7578.002.patch > > > Write and Commit responses directly write data to the channel instead of > propagating it to the next immediate handler in the channel pipeline. > Not following Netty channel pipeline model could be problematic. We don't > know whether it could cause any resource leak or performance issue especially > the internal pipeline implementation keeps changing with newer Netty releases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)