[ 
https://issues.apache.org/jira/browse/HDFS-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266247#comment-14266247
 ] 

Thanh Do commented on HDFS-7574:
--------------------------------

Hi [~cmccabe]. In Windows, the existing test (in 
{{CMakeTestCompileStrerror.cpp}}) won't work because {{strerror}} has different 
signature. Specifically, Windows does not have {{strerror_r(errorno, buf, 
len)}}. The equivalence is {{strerror_s(buf, len, errorno)}}, with different 
parameter order. This make the test fails and {{STRERROR_R_RETURN_INT}} is 
always equal {{NO}}.

A cleaner fix may be put a few lines in {{CMakeTestCompileStrerror}}:
{code}
#ifdef _WIN32
#define strerror_r(errnum, buf, buflen) strerror_s((buf), (buflen), (errnum))
#endif
{code}

Thoughts?



> Make cmake work in Windows Visual Studio 2010
> ---------------------------------------------
>
>                 Key: HDFS-7574
>                 URL: https://issues.apache.org/jira/browse/HDFS-7574
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>         Environment: Windows Visual Studio 2010
>            Reporter: Thanh Do
>            Assignee: Thanh Do
>         Attachments: HDFS-7574-branch-HDFS-6994-1.patch
>
>
> Cmake should be able to generate a solution file in Windows Visual Studio 
> 2010. This is the first step in a series of steps making libhdfs3 built 
> successfully in Windows. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to