[
https://issues.apache.org/jira/browse/HDFS-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275255#comment-14275255
]
Hudson commented on HDFS-7600:
------------------------------
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #69 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/69/])
HDFS-7600. Refine hdfs admin classes to reuse common code. Contributed by Jing
Zhao. (jing9: rev 6f3a63a41b90157c3e46ea20ca6170b854ea902e)
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CryptoAdmin.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/CacheAdmin.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/AdminHelper.java
*
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/StoragePolicyAdmin.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Refine hdfs admin classes to reuse common code
> ----------------------------------------------
>
> Key: HDFS-7600
> URL: https://issues.apache.org/jira/browse/HDFS-7600
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Reporter: Yi Liu
> Assignee: Jing Zhao
> Fix For: 2.7.0
>
> Attachments: HDFS-7600.000.patch, HDFS-7600.001.patch
>
>
> As the review comment in HDFS-7323.
> In {{StoragePolicyAdmin}} and other class under
> {{org.apache.hadoop.hdfs.tools}}, such as {{CacheAdmin}}, {{CryptoAdmin}}.
> There are too many common methods ({{getDFS}}, {{prettifyException}},
> {{getOptionDescriptionListing}} ...) and also inner class ({{HelpCommand}}),
> they are the same, it would be great if we can refine and shift them into a
> common place.
> This makes the code clean and can be re-used if we add new hdfs admin class
> in future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
