[ https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278114#comment-14278114 ]
Colin Patrick McCabe commented on HDFS-7411: -------------------------------------------- You can compute blocks per interval from blocks per second and interval length, both of which are specified. And in any case, we may eventually need to start releasing the lock occasionally during "decom intervals" as the number of blocks continues to double year-over-year. The fact that we hold the lock throughout the whole interval is an implementation detail. Anyway, I don't feel that strongly about this so if you want to keep it as a per-interval config, that's probably ok. > Refactor and improve decommissioning logic into DecommissionManager > ------------------------------------------------------------------- > > Key: HDFS-7411 > URL: https://issues.apache.org/jira/browse/HDFS-7411 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.5.1 > Reporter: Andrew Wang > Assignee: Andrew Wang > Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch, > hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch, > hdfs-7411.006.patch > > > Would be nice to split out decommission logic from DatanodeManager to > DecommissionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)