[
https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290329#comment-14290329
]
Konstantin Shvachko commented on HDFS-7659:
-------------------------------------------
+1. Looks good.
Can I ask you to add three lines to TestFileTruncate with this patch, even
though it is not ditectly related to your change.
This will fix TestFileTruncate failures as [~szetszwo] requested in HDFS-7611.
We do not risk to loose the bug since we know the problem now.
Or we can of course fix it in another jira.
The lines are as follows just in the very beginning of
{{testTruncateEditLogLoad()}}
{code}
// purge previously accumulated edits
fs.setSafeMode(SafeModeAction.SAFEMODE_ENTER);
fs.saveNamespace();
fs.setSafeMode(SafeModeAction.SAFEMODE_LEAVE);
{code}
> We should check the new length of truncate can't be a negative value.
> ---------------------------------------------------------------------
>
> Key: HDFS-7659
> URL: https://issues.apache.org/jira/browse/HDFS-7659
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Yi Liu
> Assignee: Yi Liu
> Fix For: 3.0.0
>
> Attachments: HDFS-7659.001.patch, HDFS-7659.002.patch,
> HDFS-7659.003.patch
>
>
> It's obvious that we should check the new length of truncate can't be a
> negative value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
