[ https://issues.apache.org/jira/browse/HDFS-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292745#comment-14292745 ]
Arpit Agarwal commented on HDFS-7584: ------------------------------------- Few more comments to wrap up feedback on API and protocol. # Continuing from previous, you also don't need the null check in {{PBHelper.convertStorageType}}. # DFSClient.java:3064 - Fix formatting. # Just an observation, and you don't really need to fix it. I realize you are trying to avoid a new RPC call by modifying the existing {{ClientProtocol.setQuota}} call. But it does create a confusing difference between that and {{DFSClient.setQuota}} which has two overloads and the matching overload of {{DFSClient.setQuota}} behaves differently (throws exception on null). Perhaps it is better to add a new {{ClientProtocol.setQuota}} RPC call. Either is fine though. # Do we need the new config key {{DFS_QUOTA_BY_STORAGETYPE_ENABLED_KEY}}? The administrator can already choose to avoid configuring per-type quotas so I am not sure the new configuration is useful. # {{DistributedFileSystem.setQuotaByStorageType}} - the Javadoc _and one or more [Storage Type, space Quota] pairs_ does not match the signature. Looking at the NN changes next. > Enable Quota Support for Storage Types (SSD) > --------------------------------------------- > > Key: HDFS-7584 > URL: https://issues.apache.org/jira/browse/HDFS-7584 > Project: Hadoop HDFS > Issue Type: New Feature > Components: datanode, namenode > Reporter: Xiaoyu Yao > Assignee: Xiaoyu Yao > Attachments: HDFS-7584 Quota by Storage Type - 01202015.pdf, > HDFS-7584.0.patch, HDFS-7584.1.patch, HDFS-7584.2.patch, HDFS-7584.3.patch, > HDFS-7584.4.patch, editsStored > > > Phase II of the Heterogeneous storage features have completed by HDFS-6584. > This JIRA is opened to enable Quota support of different storage types in > terms of storage space usage. This is more important for certain storage > types such as SSD as it is precious and more performant. > As described in the design doc of HDFS-5682, we plan to add new > quotaByStorageType command and new name node RPC protocol for it. The quota > by storage type feature is applied to HDFS directory level similar to > traditional HDFS space quota. -- This message was sent by Atlassian JIRA (v6.3.4#6332)