[
https://issues.apache.org/jira/browse/HDFS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292833#comment-14292833
]
Arpit Agarwal commented on HDFS-49:
-----------------------------------
+1 for the v002 patch. The test failures are almost certainly unrelated.
> MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a
> matching name is not found
> -------------------------------------------------------------------------------------------------------
>
> Key: HDFS-49
> URL: https://issues.apache.org/jira/browse/HDFS-49
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.20.204.0, 0.20.205.0, 1.1.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Labels: codereview, newbie
> Attachments: HDFS-49-002.patch, hdfs-49.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The stopDataNode method will shut down the last node in the list of nodes, if
> one matching a specific name is not found
> This is possibly not what was intended. Better to return false or fail in
> some other manner if the named node was not located
> synchronized boolean stopDataNode(String name) {
> int i;
> for (i = 0; i < dataNodes.size(); i++) {
> DataNode dn = dataNodes.get(i).datanode;
> if (dn.dnRegistration.getName().equals(name)) {
> break;
> }
> }
> return stopDataNode(i);
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
