[ 
https://issues.apache.org/jira/browse/HDFS-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lei (Eddy) Xu updated HDFS-7719:
--------------------------------
    Attachment: HDFS-7719.002.patch

[~cmccabe] Thanks much for the inputs. I updated the patch to explicitly 
constructs a block pool level path as parameter for {{BlockPoolSliceStorage}} 
to remove.

It also addressed the variable naming comment.

> BlockPoolSliceStorage could not remove storageDir.
> --------------------------------------------------
>
>                 Key: HDFS-7719
>                 URL: https://issues.apache.org/jira/browse/HDFS-7719
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-7719.000.patch, HDFS-7719.001.patch, 
> HDFS-7719.002.patch
>
>
> The parameter of {{BlockPoolSliceStorage#removeVolumes()}} is a set of volume 
> level directories, thus {{BlockPoolSliceStorage}} could not directly compare 
> its own {{StorageDirs}} with this volume-level directory. The result of that 
> is {{BlockPoolSliceStorage}} did not actually remove the targeted 
> {{StorageDirectory}}. 
> It will cause failure when remove a volume and then immediately add a volume 
> back with the same mount point..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to