[
https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302510#comment-14302510
]
Tsz Wo Nicholas Sze commented on HDFS-7411:
-------------------------------------------
> ... the old limiting scheme is seriously flawed. ...
> ... The old logic is seriously flawed...
Sure, you see it this way but some users may feel that the old code works just
fine. They may not have time to deal with new behavior. We cannot force them
to do so.
> There is no benefit to keeping around multiple broken implementations of
> things to do the same job. ...
We are not keeping multiple implementations. The old implementation will be
removed in the future.
> ... It's ready to go in, and I think it should. +1. Let's commit this today
> if there are no other comments about the patch.
Let me clarify my -1. The patch changes an existing conf property to a
different behavior. Instead, we should keep the existing behavior, deprecate
the conf property first and then remove it later.
> Refactor and improve decommissioning logic into DecommissionManager
> -------------------------------------------------------------------
>
> Key: HDFS-7411
> URL: https://issues.apache.org/jira/browse/HDFS-7411
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch,
> hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch,
> hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch,
> hdfs-7411.009.patch, hdfs-7411.010.patch
>
>
> Would be nice to split out decommission logic from DatanodeManager to
> DecommissionManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
