[
https://issues.apache.org/jira/browse/HDFS-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310019#comment-14310019
]
Tsz Wo Nicholas Sze commented on HDFS-7692:
-------------------------------------------
Some more comments:
- InterruptedException should be re-thrown as InterruptedIOException but not
ignoring it.
- Instead more wait forever as below,
{code}
+ addStorageThreadPool.awaitTermination(Long.MAX_VALUE, TimeUnit.DAYS);
{code}
how about wait a short time period, 1 minute, and print a info message? It
would be great if we can print progress for each dir.
{code}
for(; !addStorageThreadPool.awaitTermination(1, TimeUnit.MINUTES); ) {
LOG.info(..);
}
{code}
BTW, thanks a lot for working on this!
> DataStorage#addStorageLocations(...) should support MultiThread to speedup
> the upgrade of block pool at multi storage directories.
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-7692
> URL: https://issues.apache.org/jira/browse/HDFS-7692
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 2.5.2
> Reporter: Leitao Guo
> Attachments: HDFS-7692.01.patch
>
>
> {code:title=DataStorage#addStorageLocations(...)|borderStyle=solid}
> for (StorageLocation dataDir : dataDirs) {
> File root = dataDir.getFile();
> ... ...
> bpStorage.recoverTransitionRead(datanode, nsInfo, bpDataDirs,
> startOpt);
> addBlockPoolStorage(bpid, bpStorage);
> ... ...
> successVolumes.add(dataDir);
> }
> {code}
> In the above code the storage directories will be analyzed one by one, which
> is really time consuming when upgrading HDFS with datanodes have dozens of
> large volumes. MultiThread dataDirs analyzing should be supported here to
> speedup upgrade.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
