[ 
https://issues.apache.org/jira/browse/HDFS-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313328#comment-14313328
 ] 

Hadoop QA commented on HDFS-7756:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12697583/hdfs-7756-002.patch
  against trunk revision af08425.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 3 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/9506//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/9506//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9506//console

This message is automatically generated.

> Restore method signature for LocatedBlock#getLocations()
> --------------------------------------------------------
>
>                 Key: HDFS-7756
>                 URL: https://issues.apache.org/jira/browse/HDFS-7756
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: hdfs-7756-001.patch, hdfs-7756-002.patch
>
>
> This is related to HDFS-7647
> DatanodeInfoWithStorage was introduced in 
> org.apache.hadoop.hdfs.server.protocol package whereas its base class, 
> DatanodeInfo, is in org.apache.hadoop.hdfs.protocol
> Method signature change in LocatedBlock#getLocations() breaks downstream 
> project(s) (such as HBase) which may reorder DatanodeInfo's.
> DatanodeInfo is tagged @InterfaceAudience.Private
> DatanodeInfoWithStorage should have the same tag.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to