[
https://issues.apache.org/jira/browse/HDFS-6133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313513#comment-14313513
]
Yongjun Zhang commented on HDFS-6133:
-------------------------------------
Hi [~zhaoyunjiong],
Nice work! Thanks Nicholas for the review, the patch looks good to me too. One
nit:
The {{DFSOutputStream#getPinnings}} has nested loop. The search cost is
NumNodesInPipeline * NumFavoredNodes. From application point of view, I wonder
how many favoredNodes could be for a big cluster (?). If needed, we could
create a hash set when doing {{setFavoredNodes}} for quicker search. This may
not be needed if the number is small. Anyways, I don't think we need to make
this change in this jira, just something to watch out.
Thanks.
> Make Balancer support exclude specified path
> --------------------------------------------
>
> Key: HDFS-6133
> URL: https://issues.apache.org/jira/browse/HDFS-6133
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: balancer & mover, namenode
> Reporter: zhaoyunjiong
> Assignee: zhaoyunjiong
> Attachments: HDFS-6133-1.patch, HDFS-6133-10.patch,
> HDFS-6133-2.patch, HDFS-6133-3.patch, HDFS-6133-4.patch, HDFS-6133-5.patch,
> HDFS-6133-6.patch, HDFS-6133-7.patch, HDFS-6133-8.patch, HDFS-6133-9.patch,
> HDFS-6133.patch
>
>
> Currently, run Balancer will destroying Regionserver's data locality.
> If getBlocks could exclude blocks belongs to files which have specific path
> prefix, like "/hbase", then we can run Balancer without destroying
> Regionserver's data locality.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
