[
https://issues.apache.org/jira/browse/HDFS-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7716:
----------------------------
Attachment: HDFS-7716.003.patch
Thanks again for the review, Zhe! Update the patch to address your comments.
bq. BlockCollection seems a clean rebase. I guess there will be a follow-on
JIRA to extend it to support BlockInfoStriped? Conceptually, I guess the
getters can just return BlockInfo and let the callers determine the concrete
type?
Yes. I plan to do it in HDFS-7749.
bq. Comparing the replaceBlock logic in BlockInfoContiguous and
BlockInfoStriped: it seems BlockInfoStriped#replaceBlock also handles cloning
the storage locations, while the callers of BlockInfoContiguous#replaceBlock
already took care of it before calling. Maybe we should revisit this when
BlockInfoStripedUnderConstruction is in and replaceBlock is really called.
Actually BlockInfoContiguous also copies the content from the old to the new
blockInfo (by calling DatanodeStorageInfo#addBlock).
bq. Do you think ReplicaUnderConstruction needs to distinguish between
contiguous and striped forms? If not, should we move ReplicaUnderConstruction
class in trunk, as part of the BlockInfo refactor?
Yeah, we can do it in trunk. But considering ReplicaUnderConstruction may not
be updated frequently in trunk and this is not a big class, maybe it is also
fine to just do it in the EC branch.
bq. Is the plan to check the type of lastBlock and have separate logic to
handle contiguous and striped blocks?
Actually it is better to leave the BlockInfoContiguous there to remind us to
make further changes in HDFS-7749. I remove this change in the new patch.
bq. FSImageFormatPBSnapshot has an empty TODO
Updated.
bq. Just to confirm: changes on INodeFile are just code formatting right?
Yes, this is some change automatically done by Intellij.. I just removed these
changes.
> Erasure Coding: extend BlockInfo to handle EC info
> --------------------------------------------------
>
> Key: HDFS-7716
> URL: https://issues.apache.org/jira/browse/HDFS-7716
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-7716.000.patch, HDFS-7716.001.patch,
> HDFS-7716.002.patch, HDFS-7716.003.patch
>
>
> The current BlockInfo's implementation only supports the replication
> mechanism. To use the same blocksMap handling block group and its data/parity
> blocks, we need to define a new BlockGroupInfo class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
