[
https://issues.apache.org/jira/browse/HDFS-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315403#comment-14315403
]
Arpit Agarwal commented on HDFS-7723:
-------------------------------------
bq. We could change this if it is preferrable to allow setting both name space
quota and storage type quota.
No need to, I just wanted to make sure I understood this.
bq. Agree that we should name them consistently. Is it OK that we do it in a
separate JIRA for refactoring names together with issue 6 metioned below as the
current patch is already pretty large already?
Okay.
bq. This is based on that we don't need to handle quota by storage type for
legacy fsimages, which is handled in this FSImageFormat class (used by
legacy_oiv only). The current fsimage processing is done in the protobuf based
class FSImageFormatProtobuf, which is updated with typeCounts in the patch.
Okay that makes sense. Let's add a Javadoc explaining this. I am fine if you
want to do it in the follow up Jira for refactoring.
Thank you for addressing earlier feedback from HDFS-7584. I finished reviewing
most of the changes and the patch is looking great. I will review the tests
later.
> Quota By Storage Type namenode implemenation
> --------------------------------------------
>
> Key: HDFS-7723
> URL: https://issues.apache.org/jira/browse/HDFS-7723
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HDFS-7723.0.patch, HDFS-7723.1.patch, HDFS-7723.2.patch,
> HDFS-7723.3.patch, HDFS-7723.4.patch
>
>
> This includes: 1) new editlog to persist quota by storage type op 2)
> corresponding fsimage load/save the new op. 3) QuotaCount refactor to update
> usage of the storage types for quota enforcement 4) Snapshot support 5) Unit
> test update
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
