[ https://issues.apache.org/jira/browse/HDFS-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317210#comment-14317210 ]
Tsz Wo Nicholas Sze commented on HDFS-7411: ------------------------------------------- > ... would you be OK changing the default so this uses the new algorithm in > clusters where the node limit is not explicitly configured (default value for > nodes is Integer.MAX_VALUE)? Agree. This is the same as [my propose|https://issues.apache.org/jira/browse/HDFS-7411?focusedCommentId=14302030&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14302030] mentioned multiple times. The default value could be removed from hdfs-default.xml. Then then passing -1 as default in the code. Then, returning -1 means the conf is not set. > Refactor and improve decommissioning logic into DecommissionManager > ------------------------------------------------------------------- > > Key: HDFS-7411 > URL: https://issues.apache.org/jira/browse/HDFS-7411 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.5.1 > Reporter: Andrew Wang > Assignee: Andrew Wang > Attachments: hdfs-7411.001.patch, hdfs-7411.002.patch, > hdfs-7411.003.patch, hdfs-7411.004.patch, hdfs-7411.005.patch, > hdfs-7411.006.patch, hdfs-7411.007.patch, hdfs-7411.008.patch, > hdfs-7411.009.patch, hdfs-7411.010.patch > > > Would be nice to split out decommission logic from DatanodeManager to > DecommissionManager. -- This message was sent by Atlassian JIRA (v6.3.4#6332)