[ https://issues.apache.org/jira/browse/HDFS-5356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325554#comment-14325554 ]
Rakesh R commented on HDFS-5356: -------------------------------- Thanks [~cmccabe] for the reply. Yes, that would be fine for these two test cases. But as the the defect says, should we have a generic way of closing all the {{filesystems}} during minidfs#shutdown?. > MiniDFSCluster shoud close all open FileSystems when shutdown() > --------------------------------------------------------------- > > Key: HDFS-5356 > URL: https://issues.apache.org/jira/browse/HDFS-5356 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Affects Versions: 3.0.0, 2.2.0 > Reporter: haosdent > Assignee: Rakesh R > Priority: Critical > Attachments: HDFS-5356-1.patch, HDFS-5356-2.patch, HDFS-5356-3.patch, > HDFS-5356.patch > > > After add some metrics functions to DFSClient, I found that some unit tests > relates to metrics are failed. Because MiniDFSCluster are never close open > FileSystems, DFSClients are alive after MiniDFSCluster shutdown(). The > metrics of DFSClients in DefaultMetricsSystem are still exist and this make > other unit tests failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)