[ 
https://issues.apache.org/jira/browse/HDFS-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329010#comment-14329010
 ] 

Kihwal Lee commented on HDFS-7788:
----------------------------------

Although the precommit posted a +1, the test result is missing. Judging from 
the run-time, it ran many tests.  So I ran hdfs tests locally overnight. Two 
test cases failed.
{panel}
TestDFSHAAdminMiniCluster.testFencer:163 expected:<0> but was:<-1>
TestDFSUpgradeFromImage.testUpgradeFromRel1BBWImage:619->upgradeAndVerify:597->verifyFileSystem:225->verifyDir:210->dfsOpenFileWithRetries:174
 ยป IO
{panel}
I just reran the tests and they are passing.

+1 The change looks good.

> Post-2.6 namenode may not start up with an image containing inodes created 
> with an old release.
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-7788
>                 URL: https://issues.apache.org/jira/browse/HDFS-7788
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Assignee: Rushabh S Shah
>            Priority: Blocker
>         Attachments: HDFS-7788-binary.patch, rushabh.patch
>
>
> Before HDFS-4305, which was fixed in 2.1.0-beta, clients could specify 
> arbitrarily small preferred block size for a file including 0. This was 
> normally done by faulty clients or failed creates, but it was possible.
> Until 2.5, reading a fsimage containing inodes with 0 byte preferred block 
> size was allowed. So if a fsimage contained such an inode, the namenode would 
> come up fine.  In 2.6, the preferred block size is required be > 0. Because 
> of this change, the image that worked with 2.5 may not work with 2.6.
> If a cluster ran a version of hadoop earlier than 2.1.0-beta before, it is 
> under this risk even if it worked fine with 2.5.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to