[ https://issues.apache.org/jira/browse/HDFS-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334763#comment-14334763 ]
Hadoop QA commented on HDFS-7439: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700317/HDFS-7439.1.patch against trunk revision b610c68. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestFileTruncate Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9655//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9655//console This message is automatically generated. > Add BlockOpResponseProto's message to DFSClient's exception message > ------------------------------------------------------------------- > > Key: HDFS-7439 > URL: https://issues.apache.org/jira/browse/HDFS-7439 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Ming Ma > Assignee: Takanobu Asanuma > Priority: Minor > Attachments: HDFS-7439.1.patch > > > When (BlockOpResponseProto#getStatus() != SUCCESS), it helps with debugging > if DFSClient can add BlockOpResponseProto's message to the exception message > applications will get. For example, instead of > {noformat} > throw new IOException("Got error for OP_READ_BLOCK, self=" > + peer.getLocalAddressString() + ", remote=" > + peer.getRemoteAddressString() + ", for file " + file > + ", for pool " + block.getBlockPoolId() + " block " > + block.getBlockId() + "_" + block.getGenerationStamp()); > {noformat} > It could be, > {noformat} > throw new IOException("Got error for OP_READ_BLOCK, self=" > + peer.getLocalAddressString() + ", remote=" > + peer.getRemoteAddressString() + ", for file " + file > + ", for pool " + block.getBlockPoolId() + " block " > + block.getBlockId() + "_" + block.getGenerationStamp() > + ", status message " + status.getMessage()); > {noformat} > We might want to check out all the references to BlockOpResponseProto in > DFSClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)