[
https://issues.apache.org/jira/browse/HDFS-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337241#comment-14337241
]
Jing Zhao commented on HDFS-7749:
---------------------------------
Thanks for the review, Zhe! Yeah, we can do further code simplification for
BlockInfoUC. I plan to do it in a separate jira.
bq. Should BlockInfoStripedUnderConstruction#replicas represent a sorted list
of blocks in the group? If so seems we should update addReplicaIfNotPresent to
maintain the order while handling stale entries.
Yes, this is necessary when NameNode restarts before completing the block.
Currently I'm working on another patch which includes this part already. I will
create a jira and post the patch there later.
bq. BlockManager#addStoredBlock: should we still check the block belongs to a
file?
This actually has been checked by this code:
{code}
if (storedBlock == null || storedBlock.getBlockCollection() == null) {
{code}
I will update the patch after your further comments. Thanks again for the
review!
> Erasure Coding: Add striped block support in INodeFile
> ------------------------------------------------------
>
> Key: HDFS-7749
> URL: https://issues.apache.org/jira/browse/HDFS-7749
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-7749.000.patch
>
>
> This jira plan to add a new INodeFile feature to store the stripped blocks
> information in case that the INodeFile is erasure coded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
