[
https://issues.apache.org/jira/browse/HDFS-7839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340845#comment-14340845
]
Kai Zheng commented on HDFS-7839:
---------------------------------
I took a quick look at the patch and have some comments.
1. Is there a little bit conflict or overlap between this and HDFS-7349 ? It's
minor, and would be better to have some sync and align in the aspect.
2. In the meeting discussion, our conclusion is EC zone is mainly about erasure
coding parameters. So would you add to include some hard coded values like
{{NumDataBlocks, NumParityBlocks}} and etc. I will follow up to remove the
hard-coded values in related JIRAs. It's good to put {{isStripped}} here at
this phase.
3. For the new operation to create an EC zone, we need two parameters, selected
EC schema (from predefined list) and the target folder.
4. Better to move the logic of {{isStrippedFile}} out of the manager into
{{FSDirectory}}.
5. For consistency, {{ErasureCodingManager}} ==> {{ECZoneManager}}.
6. Minors:
1) In the test file, better to move the following to class header.
{code}
TODO: add tests to verify disallowed zone creations
{code}
2) The variable {{ECFilePath}} better to be {{ecFilePath}}.
> Erasure coding: move EC policies from file header to XAttr
> ----------------------------------------------------------
>
> Key: HDFS-7839
> URL: https://issues.apache.org/jira/browse/HDFS-7839
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Attachments: HDFS-7839-000.patch, HDFS-7839-001.patch
>
>
> As a quick first step to facilitate initial development and testing,
> HDFS-7347 added EC configuration in file header as one storage policy. We
> have discussed and [concluded
> |https://issues.apache.org/jira/browse/HDFS-7285?focusedCommentId=14296210&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14296210]
> that EC configurations should be part of XAttr. This JIRA aims to add the
> basic EC XAttr structure. HDFS-7337 will add configurable and pluggable
> schema info.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
