[ https://issues.apache.org/jira/browse/HDFS-7855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348271#comment-14348271 ]
Jing Zhao commented on HDFS-7855: --------------------------------- The latest patch looks good to me. The only comment is that {{isLastPacketInBlock}} does not need to acquire the lock. +1 after addressing the comments. > Separate class Packet from DFSOutputStream > ------------------------------------------ > > Key: HDFS-7855 > URL: https://issues.apache.org/jira/browse/HDFS-7855 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Li Bo > Assignee: Li Bo > Attachments: HDFS-7855-001.patch, HDFS-7855-002.patch, > HDFS-7855-003.patch, HDFS-7855-004.patch, HDFS-7855-005.patch, > HDFS-7855-006.patch > > > Class Packet is an inner class in DFSOutputStream and also used by > DataStreamer. This sub task separates Packet out of DFSOutputStream to aid > the separation in HDFS-7854. -- This message was sent by Atlassian JIRA (v6.3.4#6332)