[
https://issues.apache.org/jira/browse/HDFS-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349771#comment-14349771
]
Takanobu Asanuma commented on HDFS-7829:
----------------------------------------
Thank you for your kind review, Jing! I reply your comments:
1. This is my mistake. I will correct it, thank you!
2. I think there is the third scenario.
3) The caller set "DatanodeInfo[]", {{storageIDs}} and {{strorageTypes}}.
It is in {{ReportBadBlockAction.reportTo}} and
{{TestDatanodeManager.testSortLocatedBlocks}}. So I think we can't remove
{{setStrageIDs}} and {{setStorageTypes}} from the builder. How about this?
> Code clean up for LocatedBlock
> ------------------------------
>
> Key: HDFS-7829
> URL: https://issues.apache.org/jira/browse/HDFS-7829
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Jing Zhao
> Assignee: Takanobu Asanuma
> Priority: Minor
> Attachments: HDFS-7829.1.patch
>
>
> We can do some code cleanup for {{LocatedBlock}}, including:
> # Using a simple Builder pattern to avoid multiple constructors
> # Setting data fields like {{corrupt}} and {{offset}} to final
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
