[ https://issues.apache.org/jira/browse/HDFS-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lei (Eddy) Xu updated HDFS-7758: -------------------------------- Attachment: HDFS-7758.002.patch Updated the patch to use a {{ReferredFsVolumeList}} to replace {{FsVolumeSpi#getVolumeRefs()}} and {{FsVolumeSpi#getVolumeRef(index)}}: {code} public static interface ReferredFsVolumeList extends Iterable<FsVolumeSpi>, Closeable { /** Get the number of volumes. */ public int size(); /** Get the volume for a given index. */ public FsVolumeSpi get(int index); } {code} > Retire FsDatasetSpi#getVolumes() and use FsDatasetSpi#getVolumeRefs() instead > ----------------------------------------------------------------------------- > > Key: HDFS-7758 > URL: https://issues.apache.org/jira/browse/HDFS-7758 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Affects Versions: 2.6.0 > Reporter: Lei (Eddy) Xu > Assignee: Lei (Eddy) Xu > Attachments: HDFS-7758.000.patch, HDFS-7758.001.patch, > HDFS-7758.002.patch > > > HDFS-7496 introduced reference-counting the volume instances being used to > prevent race condition when hot swapping a volume. > However, {{FsDatasetSpi#getVolumes()}} can still leak the volume instance > without increasing its reference count. In this JIRA, we retire the > {{FsDatasetSpi#getVolumes()}} and propose {{FsDatasetSpi#getVolumeRefs()}} > and etc. method to access {{FsVolume}}. Thus it makes sure that the consumer > of {{FsVolume}} always has correct reference count. -- This message was sent by Atlassian JIRA (v6.3.4#6332)