[ 
https://issues.apache.org/jira/browse/HDFS-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370000#comment-14370000
 ] 

Arpit Agarwal commented on HDFS-7824:
-------------------------------------

The patch looks great to me. Just nitpicks, +1 otherwise and pending Jenkins.

# ContentCounts#types - looks like this is space used by the corresponding 
storage types. Could you please add a comment?
# EnumCounters#asImmutableArray - can we just call it asArray and document it 
is a shallow copy. Immutable means something else.
# ContentSummaryProto#typeQuotaInfos - missing space before equals sign.

> GetContentSummary API and its namenode implementaion for Storage Type 
> Quota/Usage
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-7824
>                 URL: https://issues.apache.org/jira/browse/HDFS-7824
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HDFS-7824.00.patch, HDFS-7824.01.patch, 
> HDFS-7824.02.patch
>
>
> This JIRA is opened to provide API support of GetContentSummary with storage 
> type quota and usage information. It includes namenode implementation, client 
> namenode RPC protocol and Content.Counts refactoring. It is required by 
> HDFS-7701 (CLI to display storage type quota and usage).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to