[
https://issues.apache.org/jira/browse/HDFS-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7864:
----------------------------
Attachment: HDFS-7864.4.patch
Thanks [~demongaorui]! The .3 patch looks good to me. Only some minors:
# I just checked the code again. Actually "replication" passed into
{{incrementSafeBlockCount}} is already the number of healthy blocks/replicas.
Thus I think we do not need to call {{numNodes}} in {{incrementSafeBlockCount}}
# In {{BlockManager#completeBlock}}, the following code also needs to be
updated for striped blocks.
{code}
namesystem.incrementSafeBlockCount(
Math.min(numNodes, minReplication), curBlock);
{code}
I just made these changes on top of your patch and uploaded the .4 version in
the jira. Some very minor code reformat is also included. Please see if the
patch looks good to you.
> Erasure Coding: Update safemode calculation for striped blocks
> --------------------------------------------------------------
>
> Key: HDFS-7864
> URL: https://issues.apache.org/jira/browse/HDFS-7864
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: GAO Rui
> Attachments: HDFS-7864.1.patch, HDFS-7864.2.patch, HDFS-7864.3.patch,
> HDFS-7864.4.patch
>
>
> We need to update the safemode calculation for striped blocks. Specifically,
> each striped block now consists of multiple data/parity blocks stored in
> corresponding DataNodes. The current code's calculation is thus inconsistent:
> each striped block is only counted as 1 expected block, while each of its
> member block may increase the number of received blocks by 1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
