[
https://issues.apache.org/jira/browse/HDFS-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384256#comment-14384256
]
Jing Zhao commented on HDFS-8003:
---------------------------------
Thanks for fixing this, [~aw] and [~brahmareddy].
bq. this seems like we're working around a problem in the Java code by patching
it at the shell level
Our initial proposal was to put this checkpoint verification logic only into
the server side (e.g., through NameNode shutdown hook). However, since the
saving namespace process can take minutes or even throw exception, there is no
way to guarantee the NN can correctly verify/do checkpoint before getting
stopped.
Instead if we add this functionality outside of NN (i.e., into the stopping NN
shell), we can make sure the checkpoint verification happens/finishes before
stopping NameNode, and the RPC timeout can provide a time bound of the
operation.
Any suggestion here, [~aw]?
> hdfs has 3 new shellcheck warnings and the related code change is questionable
> ------------------------------------------------------------------------------
>
> Key: HDFS-8003
> URL: https://issues.apache.org/jira/browse/HDFS-8003
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Brahma Reddy Battula
>
> HDFS-6353 introduced three new shell check warnings due to an unprotected
> ${HADOOP_OPTS}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
