[ 
https://issues.apache.org/jira/browse/HDFS-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384965#comment-14384965
 ] 

Zhe Zhang commented on HDFS-7907:
---------------------------------

Thanks Jing for the patch! I haven't finished but have some early comments:

# We can also have the block ID translation logic on DN. When receiving any 
read or delete commands with a group ID, it should always be able to find the 
individual block that it stores. I haven't read that part of DN code so am not 
sure how efficient it would be. This is like a gatekeeper and might be 
logically simpler than taking care of the translation in NN whenever talking to 
a DN.
# Nits in {{getStorageBlock}}:
#* A minor error in comment "Identify the block stored in the given the 
datanode storage"
#* How about {{getBlockOnStorage}}?

> Update DecommissionManager to support striped blocks
> ----------------------------------------------------
>
>                 Key: HDFS-7907
>                 URL: https://issues.apache.org/jira/browse/HDFS-7907
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-7907.000.patch
>
>
> With recent changes from HDFS-7411, we need to update DecommissionManager to 
> support striped blocks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to