[ 
https://issues.apache.org/jira/browse/HDFS-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482835#comment-14482835
 ] 

Walter Su commented on HDFS-8073:
---------------------------------

There appear to be 0 release audit warnings after applying the patch.

{color:red}-1 overall{color}.  

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version ) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

> Split BlockPlacementPolicyDefault.chooseTarget(..) so it can be easily 
> overrided.
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-8073
>                 URL: https://issues.apache.org/jira/browse/HDFS-8073
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Walter Su
>            Assignee: Walter Su
>            Priority: Trivial
>         Attachments: HDFS-8073.001.patch
>
>
> We want to implement a placement policy( eg. HDFS-7891) based on default 
> policy.  It'll be easier if we could split 
> BlockPlacementPolicyDefault.chooseTarget(..).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to