[
https://issues.apache.org/jira/browse/HDFS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908173#action_12908173
]
Jakob Homan commented on HDFS-1363:
-----------------------------------
Review:
* BlockManager::createLocatedBlock(). Originally this method did more than
just call the LocatedBlock constructor (back when it was part of FSNameSystem).
Now, since this is all it's doing and is called just two places, maybe we can
just remove it?
* FSNamesystem.java:822. Javadoc for setBlockTokens refers to old, combined
BATs, which we don't use any more.
* Since the contract of startFileInternal has been changed (now may null or a
LocatedBlock) and the method itself is quite convoluted, it would be good to
spell this out in the method's javadoc.
Otherwise, looks good as a refactor.
> startFileInternal should return the last block of the file opened for append
> as an under-construction block
> -----------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1363
> URL: https://issues.apache.org/jira/browse/HDFS-1363
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.1
>
> Attachments: appendFileSync.patch
>
>
> {{FSNamesystem.startFileInternal}} should convert the last block of the file
> opened for append to an under-construction block and return it. This will let
> remove the second synchronized section in {{FSNamesystem.appendFile()}} and
> avoid redundant computations and potential inconsistencies as stated in
> HDFS-1152.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
