[ https://issues.apache.org/jira/browse/HDFS-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493563#comment-14493563 ]
Jing Zhao commented on HDFS-8127: --------------------------------- Thanks for the review, Nicholas! bq. BootstrapStandby may format shared directories since storage.format(..) will format all directories including the shared directories. This is an existing bug I think the shared dir will not be formatted here, because {{editUrisToFormat}} only contains local dirs. I will update the patch to address your other comments and fix the failed unit tests. > NameNode Failover during HA upgrade can cause DataNode to finalize upgrade > -------------------------------------------------------------------------- > > Key: HDFS-8127 > URL: https://issues.apache.org/jira/browse/HDFS-8127 > Project: Hadoop HDFS > Issue Type: Bug > Components: ha > Affects Versions: 2.4.0 > Reporter: Jing Zhao > Assignee: Jing Zhao > Priority: Blocker > Attachments: HDFS-8127.000.patch > > > Currently for HA upgrade (enabled by HDFS-5138), we use {{-bootstrapStandby}} > to initialize the standby NameNode. The standby NameNode does not have the > {{previous}} directory thus it does not know that the cluster is in the > upgrade state. If NN failover happens, as response of block reports, the new > ANN will tell DNs to finalize the upgrade thus make it impossible to rollback > again. -- This message was sent by Atlassian JIRA (v6.3.4#6332)