[ 
https://issues.apache.org/jira/browse/HDFS-8123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493742#comment-14493742
 ] 

Rakesh R commented on HDFS-8123:
--------------------------------

Thanks [~drankye] for the comments.
bq.  For somehow feeling maybe we could use erasurecoding instead of 
erasurecode for the new proto file? How others would think?
I agree with you, {{erasurecoding}} is better one.
bq. It might not be good to have the following in the new proto file right now? 
I'm not sure.
I think, its not required to add this section. I will remove this section. I 
copied the license and header from {{hdfs.proto}}

> Erasure Coding: Better to move EC related proto messages to a separate 
> 'erasurecode.proto' file
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8123
>                 URL: https://issues.apache.org/jira/browse/HDFS-8123
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8123-001.patch, HDFS-8123-002.patch, 
> HDFS-8123-003.patch
>
>
> While reviewing the code I've noticed EC related proto messages are getting 
> added into {{hdfs.proto}}. IMHO, for better maintainability of the erasure 
> code feature, its good to move this to a separate {{erasurecode.proto}} file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to