[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493922#comment-14493922
]
Vinayakumar B commented on HDFS-7866:
-------------------------------------
Some more nits,
1. Following changes not required. Why to have same value in two places, one in
variable and one in map. In fact you need to remove from the map while
assigning to variable.
{code}+ if (options == null) {
+ options = new HashMap<>();
+ }
+ options.put(CODEC_NAME_KEY, codecName);
+ options.put(NUM_DATA_UNITS_KEY, String.valueOf(numDataUnits));
+ options.put(NUM_PARITY_UNITS_KEY, String.valueOf(numParityUnits));
+ this.options = Collections.unmodifiableMap(options);{code}
2. {{ECSchemaManager#reloadPredefined()}} should be called on initialization.
May be in constructor.
> Erasure coding: NameNode manages EC schemas
> -------------------------------------------
>
> Key: HDFS-7866
> URL: https://issues.apache.org/jira/browse/HDFS-7866
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-7866-v1.patch, HDFS-7866-v2.patch,
> HDFS-7866-v3.patch
>
>
> This is to extend NameNode to load, list and sync predefine EC schemas in
> authorized and controlled approach. The provided facilities will be used to
> implement DFSAdmin commands so admin can list available EC schemas, then
> could choose some of them for target EC zones.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
