[jira] [Commented] (HDFS-8152) Refactoring of lazy persist storage cases

[Xiaoyu Yao (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496890#comment-14496890
 ] 

Xiaoyu Yao commented on HDFS-8152:
----------------------------------

Thanks [~arpitagarwal] for refactoring these tests. The patch looks good to me 
with one minor issue: Can you reword the Precondition check message below. 
Looks like the logic is to check against invalid values instead of setting them 
both. Other than that, +1 pending Jenkins.

{code}
Preconditions.checkState(
        ramDiskReplicaCapacity < 0 || ramDiskStorageLimit == Long.MAX_VALUE,
        "Cannot specify both ramDiskReplicaCapacity and ramDiskStorageLimit");
{code}


> Refactoring of lazy persist storage cases
> -----------------------------------------
>
>                 Key: HDFS-8152
>                 URL: https://issues.apache.org/jira/browse/HDFS-8152
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-8152.01.patch
>
>
> Add a builder pattern to make it easier to test new configurations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)