[ 
https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhe Zhang updated HDFS-8191:
----------------------------
    Attachment: HDFS-8191.003.patch

Thanks Andrew for the comment. Reordering sounds good. 
{{testInjectionNonEmpty}} uses the 3-arg {{addSomeBlocks}} because it needs to 
change the starting block ID. This is kind of hard to avoid. As you mentioned 
the code in this test class isn't too neat. It's probably because 
{{SimulateFSDataset}} isn't currently heavily used. The EC branch will make 
more use of it; we should definitely revisit this code and refactor it.

> Fix byte to integer casting in SimulatedFSDataset#simulatedByte
> ---------------------------------------------------------------
>
>                 Key: HDFS-8191
>                 URL: https://issues.apache.org/jira/browse/HDFS-8191
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>            Priority: Minor
>         Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch, 
> HDFS-8191.002.patch, HDFS-8191.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to