[ https://issues.apache.org/jira/browse/HDFS-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513579#comment-14513579 ]
Vinayakumar B commented on HDFS-8242: ------------------------------------- Nice work [~rakeshr]. bq. Should we test creating a zone, create a file in the zone, and get EC info from that file (not that dir)? Currently, CLI command has not been added to get the ECInfo for a file, but, {{getZoneInfo}} command with the file as <path> gets the corresponding zonal dir's schema. Which is nothing but the file's schema itself. May be we can have a test for this. bq. What's the purpose of the following line? expCmd = expCmd.replaceAll("#LF#", System.getProperty("line.separator")); This is to replace the line separator in the expected output with the system's line separator. This is useful for the multi-line output validations. Which may fail based on env otherwise. Following is the example for expected output taken from testAclCLI.xml, after which #LF# will be replaced with CRLF/LF. {code}<expected-output># file: /dir1#LF## owner: USERNAME#LF## group: supergroup#LF#user::rwx#LF#user:charlie:r-x#LF#group::r-x#LF#group:admin:rwx#LF#mask::rwx#LF#other::r-x#LF##LF## file: /dir1/dir2#LF## owner: USERNAME#LF## group: supergroup#LF#user::rwx#LF#user:user1:r-x#LF#group::r-x#LF#group:users:rwx#LF#mask::rwx#LF#other::r-x#LF##LF#</expected-output>{code} Nits: 1. For each and every test, which modifies the system, such as {{createZone}}, we can have a cleanup command as well which reverts the state to previous. Because all tests will be run on same cluster, without any restart of cluster. ex: in current patch, second {{createZone}} command fails with zone already exists. Still test passes as no validation for this. 2. One more test for {{createZone}} without specifying the schema can be added, and later schema can be verified for this. should have default schema. > Erasure Coding: XML based end-to-end test for ECCli commands > ------------------------------------------------------------ > > Key: HDFS-8242 > URL: https://issues.apache.org/jira/browse/HDFS-8242 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Rakesh R > Assignee: Rakesh R > Attachments: HDFS-8242-001.patch, HDFS-8242-002.patch > > > This JIRA to add test cases with CLI test f/w for the commands present in > {{ECCli}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)