[
https://issues.apache.org/jira/browse/HDFS-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525117#comment-14525117
]
Hadoop QA commented on HDFS-4439:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 35s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 5s | The applied patch generated 1
new checkstyle issues (total was 4, now 4). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 39s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 22m 43s | Tests passed in
hadoop-common. |
| | | 59m 39s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12570374/HDFS-4439.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10710/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10710/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10710/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10710/console |
This message was automatically generated.
> umask-mode does not support 4-digit umask value
> -----------------------------------------------
>
> Key: HDFS-4439
> URL: https://issues.apache.org/jira/browse/HDFS-4439
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 3.0.0
> Reporter: Andy Isaacson
> Assignee: Chu Tong
> Attachments: HDFS-4439.patch
>
>
> Best practice for specifying file permissions using the legacy octal format
> is to always add a leading "0" to ensure the value is treated as octal.
> However the {{fs.permissions.umask-mode}} parsing code throws an error when
> given a 4-digit string:
> {code}
> $ hdfs dfs -Dfs.permissions.umask-mode=0000 -touchz foo.txt
> 2013-01-24 12:49:02,352 WARN permission.FsPermission
> (FsPermission.java:getUMask(245)) - Unable to parse configuration
> fs.permissions.umask-mode with value 0000 as octal or symbolic umask.
> -touchz: Unable to parse configuration fs.permissions.umask-mode with value
> 0000 as octal or symbolic umask.
> Usage: hadoop fs [generic options] -touchz <path> ...
> {code}
> There's no downside to supporting {{0000}}, so hdfs should handle it
> gracefully.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
