[ https://issues.apache.org/jira/browse/HDFS-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528983#comment-14528983 ]
Hadoop QA commented on HDFS-8296: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 36s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 30s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 31s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 2m 13s | The applied patch generated 1 new checkstyle issues (total was 209, now 209). | | {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 32s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 3m 2s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | native | 3m 14s | Pre-build of native portion | | {color:green}+1{color} | hdfs tests | 181m 21s | Tests passed in hadoop-hdfs. | | | | 224m 5s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12730043/HDFS-8296.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 9356cf8 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/10812/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HDFS-Build/10812/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/10812/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/10812/console | This message was automatically generated. > BlockManager.getUnderReplicatedBlocksCount() is not giving correct count if > namenode in safe mode. > --------------------------------------------------------------------------------------------------- > > Key: HDFS-8296 > URL: https://issues.apache.org/jira/browse/HDFS-8296 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.6.0 > Reporter: surendra singh lilhore > Assignee: surendra singh lilhore > Attachments: HDFS-8296.patch > > > {{underReplicatedBlocksCount}} update by the {{updateState()}} API. > {code} > void updateState() { > pendingReplicationBlocksCount = pendingReplications.size(); > underReplicatedBlocksCount = neededReplications.size(); > corruptReplicaBlocksCount = corruptReplicas.size(); > } > {code} > but this will not call when NN in safe mode. This is happening because > "computeDatanodeWork()" we will return 0 if NN in safe mode > {code} > int computeDatanodeWork() { > ......... > if (namesystem.isInSafeMode()) { > return 0; > } > .................... > .................... > this.updateState(); > .................... > .................... > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)