[
https://issues.apache.org/jira/browse/HDFS-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529817#comment-14529817
]
Hadoop QA commented on HDFS-8321:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 1s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 44s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 51s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 20s | The applied patch generated 1
new checkstyle issues (total was 275, now 275). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 38s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 3m 18s | The patch appears to introduce 1
new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 18s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 166m 45s | Tests failed in hadoop-hdfs. |
| | | 210m 54s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| | Redundant nullcheck of StringBuilder.toString(), which is known to be
non-null in
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCachePool(CachePoolInfo,
boolean) Redundant null check at FSNamesystem.java:is known to be non-null in
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.addCachePool(CachePoolInfo,
boolean) Redundant null check at FSNamesystem.java:[line 7771] |
| Failed unit tests | hadoop.hdfs.server.namenode.TestCacheDirectives |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12730654/HDFS-8321.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 4da8490 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10823/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/10823/artifact/patchprocess/whitespace.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/10823/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10823/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10823/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10823/console |
This message was automatically generated.
> CacheDirectives and CachePool operations should throw RetriableException in
> safemode
> ------------------------------------------------------------------------------------
>
> Key: HDFS-8321
> URL: https://issues.apache.org/jira/browse/HDFS-8321
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-8321.000.patch, HDFS-8321.001.patch
>
>
> Operations such as {{addCacheDirectives()}} throws {{SafeModeException}} when
> the NN is in safemode:
> {code}
> if (isInSafeMode()) {
> throw new SafeModeException(
> "Cannot add cache directive", safeMode);
> }
> {code}
> While other NN operations throws {{RetriableException}} when HA is enabled:
> {code}
> void checkNameNodeSafeMode(String errorMsg)
> throws RetriableException, SafeModeException {
> if (isInSafeMode()) {
> SafeModeException se = new SafeModeException(errorMsg, safeMode);
> if (haEnabled && haContext != null
> && haContext.getState().getServiceState() == HAServiceState.ACTIVE
> && shouldRetrySafeMode(this.safeMode)) {
> throw new RetriableException(se);
> } else {
> throw se;
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
