[ 
https://issues.apache.org/jira/browse/HDFS-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531057#comment-14531057
 ] 

Arpit Agarwal commented on HDFS-8157:
-------------------------------------

Thanks for the review. This was a very preliminary patch. I'll post an updated 
patch when I get some more time to work on this. I might just post a 
consolidated patch for this and HDFS-8192.

bq. Maybe I am missing something, but I don't understand the purpose behind 
releaseRoundDown. Why would we round down to a page size when allocating or 
releasing memory?
For the common case when the finalized length is not a multiple of the page 
size. e.g. Initial reservation = 16KB, page size = 4KB. A The block is 
finalized at 11KB. We want to release round_down(16 - 11) and not round up.

> Writes to RAM DISK reserve locked memory for block files
> --------------------------------------------------------
>
>                 Key: HDFS-8157
>                 URL: https://issues.apache.org/jira/browse/HDFS-8157
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-8157.01.patch
>
>
> Per discussion on HDFS-6919, the first step is that writes to RAM disk will 
> reserve locked memory via the FsDatasetCache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to