[ 
https://issues.apache.org/jira/browse/HDFS-5461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HDFS-5461:
------------------------------
    Status: Open  (was: Patch Available)

[~xieliang007] are you still interested in working on this patch? can you 
update it based on the feedback thus far?

My summary from reading through:

* Add a configuration for "maximum direct buffer pool size in bytes"
* Trigger fall-back when over this limit
* update the "used memory" stat to be in bytes
* add a test that sets the max pool size very small and trigger the limit
* make sure we have condition testing for both BlockReaderLocal creation and  
BlockReaderFactory.getLegacyBlockReaderLocal

> fallback to non-ssr(local short circuit reads) while oom detected
> -----------------------------------------------------------------
>
>                 Key: HDFS-5461
>                 URL: https://issues.apache.org/jira/browse/HDFS-5461
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.2.0, 3.0.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-5461.txt
>
>
> Currently, the DirectBufferPool used by ssr feature seems doesn't have a 
> upper-bound limit except DirectMemory VM option. So there's a risk to 
> encounter direct memory oom. see HBASE-8143 for example.
> IMHO, maybe we could improve it a bit:
> 1) detect OOM or reach a setting up-limit from caller, then fallback to 
> non-ssr
> 2) add a new metric about current raw consumed direct memory size.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to