[
https://issues.apache.org/jira/browse/HDFS-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535312#comment-14535312
]
Hadoop QA commented on HDFS-1605:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 37s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 36s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 14s | The applied patch generated
554 new checkstyle issues (total was 627, now 621). |
| {color:red}-1{color} | whitespace | 0m 1s | The patch has 34 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 4s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 13s | Pre-build of native portion |
| {color:red}-1{color} | hdfs tests | 166m 11s | Tests failed in hadoop-hdfs. |
| | | 208m 55s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.tracing.TestTraceAdmin |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731455/HADOOP-1605-trunk.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6f62267 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10872/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/10872/artifact/patchprocess/whitespace.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10872/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10872/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10872/console |
This message was automatically generated.
> Convert DFSInputStream synchronized sections to a ReadWrite lock
> ----------------------------------------------------------------
>
> Key: HDFS-1605
> URL: https://issues.apache.org/jira/browse/HDFS-1605
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Reporter: dhruba borthakur
> Labels: BB2015-05-TBR
> Attachments: DFSClientRWlock.1.txt, DFSClientRWlock.3.txt,
> HADOOP-1605-trunk.patch, HDFS-1605.txt
>
>
> Hbase does concurrent preads from multiple threads to different blocks of the
> same hdfs file. Each of these pread calls invoke
> DFSInputStream.getFileLength() and DFSInputStream.getBlockAt(). These methods
> are "synchronized", thus causing all the concurrent threads to serialize. It
> would help performance to convert this to a Read/Write lock
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
