[ https://issues.apache.org/jira/browse/HDFS-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536285#comment-14536285 ]
Masatake Iwasaki commented on HDFS-3302: ---------------------------------------- Thanks for the patch, [~pmkiran19]. I think examples of command lines and outputs is too specific and verbose for Architecture doc. How about just emphasizing that trash folder is disabled by default in ["File Deletes and Undeletes" section|http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-hdfs/HdfsDesign.html#File_Deletes_and_Undeletes]? For example, {noformat} - When a file is deleted by a user or an application, it is not immediately removed from HDFS. ... + If you enabled trash directory, a file deleted by a user or an application is not immediately removed from HDFS. ... {noformat} Also, a link to Architecture Guide in [the usage of -expunge command in "FileSystem Shell" document|http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-common/FileSystemShell.html#expunge] could be more specific. {noformat} -Empty the Trash. Refer to the [HDFS Architecture Guide](../hadoop-hdfs/HdfsDesign.html) for ... +Empty the Trash. Refer to the [HDFS Architecture Guide](../hadoop-hdfs/HdfsDesign.html#File_Deletes_and_Undeletes) for ... {noformat} It could be good to add same notice to the usage of -rm command too. > Review and improve HDFS trash documentation > ------------------------------------------- > > Key: HDFS-3302 > URL: https://issues.apache.org/jira/browse/HDFS-3302 > Project: Hadoop HDFS > Issue Type: Improvement > Components: documentation > Affects Versions: 3.0.0 > Reporter: Harsh J > Assignee: Harsh J > Labels: docs > Attachments: HDFS-3302.patch > > > Improve Trash documentation for users. > (0.23 published release docs are missing original HDFS docs btw...) > A set of FAQ-like questions can be found on HDFS-2740 > I'll update the ticket shortly with the areas to cover in the docs, as > enabling trash by default (HDFS-2740) would be considered as a wide behavior > change per its follow ups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)