[ 
https://issues.apache.org/jira/browse/HDFS-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544618#comment-14544618
 ] 

Zhe Zhang commented on HDFS-8375:
---------------------------------

Nice work Vinay! The patch LGTM overall. A few nits:
# Maybe let's take this chance to update {{schema}} to {{ecSchema}} in 
{HdfsFileStatus}}?
# With this change we should probably revisit the relationship 
{{ErasureCodingInfo}} and {{ErasureCodingZoneInfo}}. If {{ErasureCodingInfo}} 
is to represent all EC-related info for a file, then it should include cell 
size, and this structure can be used to encapsulate all required info in places 
like {{StripedBlockUtil}}. 

I haven't yet finished reviewing the {{FSNamesystem}} changes, will complete my 
review later today.

> Add cellSize as an XAttr to ECZone
> ----------------------------------
>
>                 Key: HDFS-8375
>                 URL: https://issues.apache.org/jira/browse/HDFS-8375
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-8375-HDFS-7285-01.patch
>
>
> Add {{cellSize}} as an Xattr for ECZone. as discussed 
> [here|https://issues.apache.org/jira/browse/HDFS-8347?focusedCommentId=14539108&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14539108]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to