[
https://issues.apache.org/jira/browse/HDFS-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545850#comment-14545850
]
Uma Maheswara Rao G commented on HDFS-8332:
-------------------------------------------
{quote}
In this kind of situation, I like to consider if the risks outweigh the
benefits. This change isn't an absolute requirement to fix a critical bug or
ship a new feature. Considering that, I think a conservative approach would be
to re-target this patch to trunk/3.0.0 and revert from branch-2. We can set the
incompatible flag and enter a release note for 3.0.0 stating that callers who
were dependent on the buggy behavior must fix their code when upgrading. What
do others think of this?
{quote}
Yes, The strange part here is api calls working even after streamClosed I
think. So users simply using even closed fs for some operation like
setReplication. This we noticed from test cases already.
Since this is not so critical issue, we can revert from branch-2. I am fine
with that. Even though issue comes with wrong usage, some users might have
that wrong code already in their app. So, upgrading system would expect code
change from users. In this perspective we can mark this as incompatible change.
Let's revert from branch-2 and leave it from trunk. What do you think
Vinay/Rakesh?
> DFS client API calls should check filesystem closed
> ---------------------------------------------------
>
> Key: HDFS-8332
> URL: https://issues.apache.org/jira/browse/HDFS-8332
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 2.8.0
>
> Attachments: HDFS-8332-000.patch, HDFS-8332-001.patch,
> HDFS-8332-002-Branch-2.patch, HDFS-8332-002.patch,
> HDFS-8332.001.branch-2.patch
>
>
> I could see {{listCacheDirectives()}} and {{listCachePools()}} APIs can be
> called even after the filesystem close. Instead these calls should do
> {{checkOpen}} and throws:
> {code}
> java.io.IOException: Filesystem closed
> at org.apache.hadoop.hdfs.DFSClient.checkOpen(DFSClient.java:464)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
