[ https://issues.apache.org/jira/browse/HDFS-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545967#comment-14545967 ]
Jing Zhao commented on HDFS-8394: --------------------------------- Thanks for working on this, Haohui. The patch looks good to me. Some comments: # After the refactoring, {{getNewBlockTargets}} only does checks and does not return target DN locations. Thus we may need to rename both the function and the {{NewBlockTargetResult}} class. # {{getPermissionChecker}} should be called out of the lock. # Need to fix checkstyle and whitespace warnings. > Move getAdditionalBlock() and related functionalities into a separate class > --------------------------------------------------------------------------- > > Key: HDFS-8394 > URL: https://issues.apache.org/jira/browse/HDFS-8394 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-8394.000.patch, HDFS-8394.001.patch, > HDFS-8394.002.patch, HDFS-8394.003.patch, HDFS-8394.004.patch > > > This jira proposes to move the implementation of getAdditionalBlock() and > related functionalities to a separate class to open up the possibilities of > further refactoring and improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)