[
https://issues.apache.org/jira/browse/HDFS-8210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551669#comment-14551669
]
Jitendra Nath Pandey commented on HDFS-8210:
--------------------------------------------
Thanks for the review Chris.
1. I have added some comments on what BitWiseTrieContainerMap does. I would add
more comments as the code stabilizes.
2. Added a TODO to implement iterator.
3. Synchronized the initPrefix method. The prefix will map to the bucketId,
therefore I have used the lower order bits which are easier to think about. The
other functions like getTrieMap are internal methods therefore higher order bit
manipulation will be contained in the class. We can revisit this as we see
initPrefix being used.
4. Added a TODO to make addBits idempotent. Its a great idea.
5. Added TODO to make replication factor flexible.
6. Added a comment.
7. Added a test.
> Ozone: Implement storage container manager
> -------------------------------------------
>
> Key: HDFS-8210
> URL: https://issues.apache.org/jira/browse/HDFS-8210
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HDFS-8210-HDFS-7240.1.patch,
> HDFS-8210-HDFS-7240.2.patch, HDFS-8210-HDFS-7240.3.patch
>
>
> The storage container manager collects datanode heartbeats, manages
> replication and exposes API to lookup containers. This jira implements
> storage container manager by re-using the block manager implementation in
> namenode. This jira provides initial implementation that works with
> datanodes. The additional protocols will be added in subsequent jiras.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
