[ 
https://issues.apache.org/jira/browse/HDFS-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553416#comment-14553416
 ] 

Jing Zhao commented on HDFS-8421:
---------------------------------

# We do not need to remove the following check from the beginning of the 
startFile call.
{code}
checkOperation(OperationCategory.WRITE);
{code}
# The safemode check should only be in the real file creation section
# The following log seems unnecessary to me: in case of Standby NN this change 
will cause a lot of warning msg in the log
{code}
+    } catch (IOException e) {
+      NameNode.stateChangeLog.warn("DIR* NameSystem.startFile: " + src + " " +
+          e.getMessage());
{code}

> Move startFile() and related operations into FSDirWriteFileOp
> -------------------------------------------------------------
>
>                 Key: HDFS-8421
>                 URL: https://issues.apache.org/jira/browse/HDFS-8421
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-8421.000.patch, HDFS-8421.001.patch
>
>
> This jira proposes to move startFile() and related functions into 
> FSDirWriteFileOp.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to