[ 
https://issues.apache.org/jira/browse/HDFS-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557198#comment-14557198
 ] 

Walter Su commented on HDFS-8466:
---------------------------------

HDFS-8113 removed 
{code}
-    this(from, from.bc.getBlockReplication());
{code}
why we still have this in branch
{code}
this(from, from.getBlockCollection().getPreferredBlockReplication());
{code}
Can we just merged HDFS-8113 into branch to remove this line as well? I don't 
know well about rebase, just asking.

> Refactor BlockInfoContiguous and fix NPE in 
> TestBlockInfo#testCopyConstructor()
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-8466
>                 URL: https://issues.apache.org/jira/browse/HDFS-8466
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-8466-HDFS-7285-01.patch
>
>
> HDFS-7716 refactored BlockInfoContiguous.java
> Since then TestBlockInfo#testCopyConstructor(..) fails with NPE.
> Along with fixing test failure, some of the code can be refactored to re-use 
> code from BlockInfo.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to